From 25b6d4bd0bbc05125d0c642098fb70c24bd8c4ff Mon Sep 17 00:00:00 2001 From: Federico Date: Fri, 31 Jul 2026 17:20:08 +0800 Subject: [PATCH] `suggest-commit-title-limit` - Restore feature --- source/features/monospace-textareas.css | 6 +++++- source/features/suggest-commit-title-limit.css | 12 +++--------- source/features/suggest-commit-title-limit.tsx | 10 ++-------- 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/source/features/monospace-textareas.css b/source/features/monospace-textareas.css index cfb7dd337ce4..6c5d8e51214b 100644 --- a/source/features/monospace-textareas.css +++ b/source/features/monospace-textareas.css @@ -1,7 +1,11 @@ /* Use monospace font in various fields */ /* Use same font-family as GitHub style for `code` */ -/* https://github.com/refined-github/sandbox/pull/10#issue-comment-box */ +/* Test URL: https://github.com/refined-github/refined-github/pull/9905 */ +[class^='prc-PageLayout-Header'] input, +/* Test URL: https://github.com/refined-github/sandbox/compare/default-a...new?expand=1 */ +input[name='pull_request[title]'], +/* Test URL: https://github.com/refined-github/sandbox/pull/10#issue-comment-box */ [placeholder='Add an optional extended description…'], /* Test URL: https://github.com/refined-github/refined-github/edit/main/.editorconfig */ #commit-message-input, diff --git a/source/features/suggest-commit-title-limit.css b/source/features/suggest-commit-title-limit.css index ae712fb30a6d..fd81f7a06f46 100644 --- a/source/features/suggest-commit-title-limit.css +++ b/source/features/suggest-commit-title-limit.css @@ -5,9 +5,7 @@ /* Limit width of commit title to 72 characters */ .rgh-suggest-commit-title-limit { [data-testid='mergebox-partial'] input[type='text'], - #commit-message-input, - /* TODO [2026-08-01]: Remove */ - #commit-summary-input { + #commit-message-input { box-sizing: content-box; /* Exclude padding/border from `width`; No need to mess with `calc` */ width: 72ch; @@ -20,12 +18,8 @@ } } -/* TODO [2026-09-01]: Remove */ -#pull_request_title, -/* TODO [2026-08-01]: Remove */ -#commit-summary-input, -/* TODO: Remove after legacy PR files view is removed */ -#issue_title { +[class^='prc-PageLayout-Header'] input, /* `isPR` */ +input[name='pull_request[title]'] /* `isCompare` */ { &.rgh-title-over-limit { border-color: var(--rgh-limit-color); background-color: color-mix( diff --git a/source/features/suggest-commit-title-limit.tsx b/source/features/suggest-commit-title-limit.tsx index fb4adea738eb..f01d9ed240c4 100644 --- a/source/features/suggest-commit-title-limit.tsx +++ b/source/features/suggest-commit-title-limit.tsx @@ -35,7 +35,7 @@ async function validatePrTitleDelegate({delegateTarget}: DelegateEvent { abortableClassName(document.body, signal, 'rgh-suggest-commit-title-limit'); @@ -43,13 +43,7 @@ async function init(signal: AbortSignal): Promise { onCommitTitleUpdate(validateCommitTitle, signal); delegate( - [ - ...currentPrTitleSelectors, - 'input#pull_request_title', - // Old `isCompare` - // TODO [2026-09-01]: Remove - 'input#issue_title', // Old `isPR` view - TODO: Remove after legacy PR files view is removed - ], + currentPrTitleSelectors, 'input', validatePrTitleDelegate, {signal, passive: true},