Skip to content

Remove timing-sensitive NVML total-energy test - #2644

Open
rwgk wants to merge 1 commit into
NVIDIA:mainfrom
rwgk:remove_test_device_get_total_energy_consumption
Open

Remove timing-sensitive NVML total-energy test#2644
rwgk wants to merge 1 commit into
NVIDIA:mainfrom
rwgk:remove_test_device_get_total_energy_consumption

Conversation

@rwgk

@rwgk rwgk commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses cuda-python-private issue 509.

Removes the timing-sensitive test_device_get_total_energy_consumption bootstrap test. NVML does not guarantee a refresh cadence, so requiring the cumulative energy counter to advance within 150 ms can fail even when the binding is working correctly.

Checklist

  • New or existing tests cover these changes. (Not applicable: this removes a timing-sensitive bootstrap test without changing product code.)
  • The documentation is up to date with these changes. (No documentation changes are required.)

@rwgk rwgk added this to the cuda.bindings next milestone Aug 16, 2026
@rwgk rwgk added P0 High priority - Must do! test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Aug 16, 2026
@rwgk rwgk self-assigned this Aug 16, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
rwgk marked this pull request as ready for review August 16, 2026 05:15
@rwgk

rwgk commented Aug 16, 2026

Copy link
Copy Markdown
Contributor Author

I also looked into whether removing this test should leave behind a comment such as # [Skipping] pynvml.nvmlDeviceGetTotalEnergyConsumption.

I found that the existing [Skipping] comments in this file were copied verbatim from the upstream pynvml 11.5.3 test when the file was introduced; they are not maintained as a ledger of tests later removed. As direct precedent, #2483 removed test_device_get_nvlink_capability from this same file without adding a corresponding [Skipping] comment. I therefore left the removal as-is.

@rwgk
rwgk requested a review from mdboom August 16, 2026 05:20
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-2644/

https://nvidia.github.io/cuda-python/pr-preview/pr-2644/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-2644/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-2644/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom Awaiting requested review from mdboom

At least 1 approving review is required to merge this pull request.

Assignees

@rwgk rwgk

Labels

cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! test Improvements or additions to tests

Projects

None yet

Milestone

cuda.bindings 13.4.0 & 12.9.8

Development

Successfully merging this pull request may close these issues.

1 participant

@rwgk