feat: support alias_attribute as valid keys for filter - #6956
Open
brunohkbx wants to merge 1 commit into
Open
Conversation
Member
|
Does this work with other filter types? What if using a Ransack based filter? This just needs a rebase and push to run CI. Thank you. |
Given a model with an alias_attribute like so: `alias_attribute :title_alias, :title` Then it will be possible to use the alias as a valid filter: `filter :title_alias, as: :select`
javierjulio
force-pushed
the
feat/support-alias_attribute
branch
from
March 13, 2023 01:48
d141ba0 to
00e298b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6956 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 308 308
Lines 11306 11321 +15
=======================================
+ Hits 11247 11262 +15
Misses 59 59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given a model with an alias_attribute like so:
alias_attribute :title_alias, :titleThen it will be possible to use the alias as a valid filter:
filter :title_alias, as: :select