feat: add selector support to require-baseline - #61
Merged
Conversation
Contributor
Author
|
I wasn't sure how to handle selectors used within Example CSS: @supports selector(.example) {}AST: {
"type": "Function",
"loc": {
"source": "<unknown>",
"start": {
"offset": 10,
"line": 1,
"column": 11
},
"end": {
"offset": 28,
"line": 1,
"column": 29
}
},
"name": "selector",
"children": [
{
"type": "Raw",
"loc": {
"source": "<unknown>",
"start": {
"offset": 19,
"line": 1,
"column": 20
},
"end": {
"offset": 27,
"line": 1,
"column": 28
}
},
"value": ".example"
}
]
} |
nzakas
reviewed
Feb 24, 2025
nzakas
requested changes
Feb 24, 2025
nzakas
left a comment
Member
There was a problem hiding this comment.
Thanks for getting this started. The basics are here, there are a couple of edge cases that need addressing.
Member
|
This is looking really good. I think the last step here is to update the docs with some examples that use |
Contributor
Author
|
Great thanks, added another example to the docs. |
nzakas
approved these changes
Feb 25, 2025
nzakas
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks so much for this. Great work.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add support for validating the Baseline status of selectors like
:has()What changes did you make? (Give an overview)
Selectorhandler that checks the validity of all child nodesRelated Issues
Fixes #60
Is there anything you'd like reviewers to focus on?