fix: Bump pymssql to >=2.3.6 for macOS arm64 wheel support - #6668
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6668 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 414 414
Lines 50134 50134
Branches 7173 7173
=======================================
Hits 23285 23285
Misses 25212 25212
Partials 1637 1637
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
adarshsm
force-pushed
the
fix/pymssql-arm64-wheel
branch
from
July 30, 2026 13:27
0cd6698 to
ec88b4d
Compare
The `azure` extra pinned `pymssql<2.3.3`, which resolves to 2.3.2. That release ships no macOS arm64 wheel, so `make install-python-dependencies-dev` fails building pymssql from source on Apple Silicon (feast-dev#5636). The `<2.3.3` cap was added in feast-dev#5193 because pymssql 2.3.3 dropped its Linux wheels, which the offline feature-server image build relies on. pymssql 2.3.6+ restored the Linux wheels and added macOS arm64 wheels, so `>=2.3.6` fixes Apple Silicon dev installs without regressing the offline build. Regenerated the py3.10/3.11/3.12 CI requirement locks (pymssql 2.3.2 -> 2.3.13) and the pixi lock. pymssql has no runtime dependencies, so no other packages change. Fixes feast-dev#5636
adarshsm
force-pushed
the
fix/pymssql-arm64-wheel
branch
from
July 30, 2026 13:33
ec88b4d to
1c2ad51
Compare
ntkathole
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make install-python-dependencies-devfails on macOS arm64 (Apple Silicon) while buildingpymssqlfrom source (#5636):The
azureoptional extra pinspymssql<2.3.3, which resolves to 2.3.2 — a release that ships no macOS arm64 wheel, so it falls back to a source (FreeTDS/Cython) build that fails. Because theciextra pulls inazure, every contributor running the dev install on Apple Silicon hits this.Why the cap existed: the
<2.3.3pin was added in #5193 ("offline source builds of the feature-server image") because pymssql 2.3.3 dropped its Linux wheels, which the offline (no-network) image build relies on.Why bumping is safe: pymssql 2.3.6+ restored the Linux wheels and added macOS arm64 wheels, so
>=2.3.6fixes Apple Silicon dev installs without regressing the offline-build reason the cap was introduced:Which issue(s) this PR fixes:
Fixes #5636
Misc
py3.10/3.11/3.12-ci-requirements.txtwithuv pip compile -p <ver> --no-strip-extras pyproject.toml --extra ci --generate-hashes.pymssqlhas no runtime dependencies (requires_dist: None), so the lock diff is limited to thepymssqlversion + hashes — no other packages change.pip install --only-binary=:all: pymssql==2.3.2→No matching distribution found, whilepymssql>=2.3.6installs2.3.13from a wheel and imports cleanly.>=2.3.6) to match the siblingpyodbc>=4.0.30in the same extra; happy to add an upper bound (e.g.<2.4) if preferred.Checks
git commit -s)Testing Strategy