fix: Preinstall DuckDB delta extension for tests - #6744
Open
larrysingleton007 wants to merge 1 commit into
Open
Conversation
Fixes feast-dev#6743 Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6744 +/- ##
==========================================
- Coverage 46.82% 46.80% -0.02%
==========================================
Files 415 415
Lines 50406 50406
Branches 7215 7215
==========================================
- Hits 23601 23594 -7
- Misses 25155 25161 +6
- Partials 1650 1651 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The DuckDB offline suite starts 8 pytest workers against a shared extension cache. On a fresh Linux runner, multiple workers can decide the
deltaextension is missing and race to install it. This has failed 3 unrelated CI runs with a DuckDB extension-file lock conflict.This adds a serial Pixi task that installs
deltabefore pytest starts. The existing test task depends on it, so workers only need to load the installed extension.Which issue(s) this PR fixes:
Fixes #6743
Checks
git commit -s)Testing Strategy
Ran the task from an empty DuckDB cache and confirmed Pixi completed
install-delta-extensionbefore starting pytest. A fresh connection reporteddeltaas installed and not loaded. The complete 8-worker suite passed with 84 tests passed and 5 skipped.Self-review
No issues found in the one-file task configuration change.
Misc
Please add
kind/bugandok-to-test.