Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

test: fine grained access control for Postgres dialect. - #2341

Merged
gcf-merge-on-green[bot] merged 6 commits into
googleapis:mainfrom
arpan14:fgac-pr
Jun 6, 2023
Merged

test: fine grained access control for Postgres dialect.#2341
gcf-merge-on-green[bot] merged 6 commits into
googleapis:mainfrom
arpan14:fgac-pr

Conversation

@arpan14

@arpan14 arpan14 commented Mar 21, 2023

Copy link
Copy Markdown
Contributor
  • Parameterised the existing tests to support additional dialect POSTGRESQL.

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 21, 2023
@arpan14 arpan14 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 21, 2023
@arpan14
arpan14 marked this pull request as ready for review April 17, 2023 15:23
@arpan14
arpan14 requested a review from a team April 17, 2023 15:23

@asthamohta asthamohta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajatbhatta rajatbhatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a few suggestions.

arpan14 and others added 2 commits June 6, 2023 11:06
…/ITDatabaseRolePermissionTest.java

Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
…/ITDatabaseRolePermissionTest.java

Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
@arpan14 arpan14 added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 6, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot
gcf-owl-bot Bot requested a review from a team June 6, 2023 09:02
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit ee72615 into googleapis:main Jun 6, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants