Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

docs: remove doc reference for THEN RETURN for batchUpdate - #2639

Closed
xinjiacs wants to merge 1 commit into
googleapis:mainfrom
xinjiacs:patch-returning-batch-api
Closed

docs: remove doc reference for THEN RETURN for batchUpdate#2639
xinjiacs wants to merge 1 commit into
googleapis:mainfrom
xinjiacs:patch-returning-batch-api

Conversation

@xinjiacs

@xinjiacs xinjiacs commented Sep 25, 2023

Copy link
Copy Markdown

Update the documentation of batch dml API to make it less confusing: calling out that you can use DML RETURNING in an API that doesn't support returning a result is weird.

…calling out that you can use DML RETURNING in an API that doesn't support returning a result is weird.
@xinjiacs
xinjiacs requested a review from a team September 25, 2023 20:20
@google-cla

google-cla Bot commented Sep 25, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Sep 25, 2023

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 25, 2023
@olavloite olavloite changed the title Update the documentation of batch dml API to make it less confusing: … docs: remove doc reference for THEN RETURN for batchUpdate Sep 26, 2023
@olavloite

Copy link
Copy Markdown
Collaborator

@xinjiacs I took the liberty of creating #2644 instead, so we can quickly get around the missing CLA issue. Hope you don't mind.

@olavloite olavloite closed this Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants