Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c62584c
chore: integration test fix
surbhigarg92 Jan 11, 2024
e7d385b
Merge branch 'googleapis:main' into main
surbhigarg92 Mar 4, 2024
e57b897
Merge branch 'googleapis:main' into main
surbhigarg92 Mar 4, 2024
c0c935e
Merge branch 'googleapis:main' into main
surbhigarg92 Mar 8, 2024
8875f2c
Merge branch 'googleapis:main' into main
surbhigarg92 Mar 26, 2024
a903eec
Merge branch 'googleapis:main' into main
surbhigarg92 Apr 9, 2024
50914dc
Merge branch 'googleapis:main' into main
surbhigarg92 Jun 17, 2024
95aa578
Merge branch 'googleapis:main' into main
surbhigarg92 Jun 26, 2024
738804b
Merge branch 'googleapis:main' into main
surbhigarg92 Jul 3, 2024
b53a82f
Merge branch 'googleapis:main' into main
surbhigarg92 Jul 31, 2024
eb858ac
Merge branch 'googleapis:main' into main
surbhigarg92 Aug 6, 2024
163699b
Merge branch 'googleapis:main' into main
surbhigarg92 Aug 8, 2024
0f6fda3
Merge branch 'googleapis:main' into main
surbhigarg92 Sep 23, 2024
4b173ba
Merge branch 'googleapis:main' into main
surbhigarg92 Sep 30, 2024
4261105
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 10, 2024
6a77a21
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 21, 2024
c597b74
Merge remote-tracking branch 'upstream/main'
surbhigarg92 Oct 21, 2024
56df6b4
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 22, 2024
bd4647c
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 24, 2024
4b2f196
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 28, 2024
207b382
Merge branch 'googleapis:main' into main
surbhigarg92 Oct 30, 2024
e3b4394
Merge branch 'googleapis:main' into main
surbhigarg92 Nov 7, 2024
22b1c5d
Merge branch 'googleapis:main' into main
surbhigarg92 Nov 8, 2024
fb26cc4
Merge branch 'googleapis:main' into main
surbhigarg92 Nov 11, 2024
cceb81a
fix: session span events
surbhigarg92 Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2204,11 +2204,6 @@ class Database extends common.GrpcServiceObject {
span.addEvent('Using Session', {'session.id': session?.id});
transaction!._observabilityOptions = this._observabilityOptions;
this._releaseOnEnd(session!, transaction!, span);
} else if (isSessionNotFoundError(err as grpc.ServiceError)) {
span.addEvent('No session available', {
'session.id': session?.id,
});
setSpanError(span, err);
} else {
setSpanError(span, err);
}
Expand Down Expand Up @@ -2486,11 +2481,7 @@ class Database extends common.GrpcServiceObject {
pool.getSession((err, session_) => {
const span = getActiveOrNoopSpan();
if (err) {
if (isSessionNotFoundError(err as grpc.ServiceError)) {
span.addEvent('No session available', {
'session.id': session?.id,
});
}
setSpanError(span, err as ServiceError);
destroyStream(err as ServiceError);
return;
}
Expand Down Expand Up @@ -3411,10 +3402,11 @@ class Database extends common.GrpcServiceObject {
this.pool_.release(session);
}
} catch (e) {
if (!isSessionNotFoundError(e as ServiceError)) {
if (isSessionNotFoundError(e as ServiceError)) {
span.addEvent('No session available', {
'session.id': sessionId,
});
} else {
span.end();
throw e;
}
Expand Down