This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: add owlbot rule to preserve app_profile_id header - #1115
Merged
Conversation
daniel-sanche
force-pushed
the
patch_app_profile_header
branch
from
April 26, 2025 00:17
00e8c80 to
a7e2110
Compare
daniel-sanche
force-pushed
the
patch_app_profile_header
branch
from
April 26, 2025 00:30
7995202 to
ab69446
Compare
daniel-sanche
force-pushed
the
patch_app_profile_header
branch
from
April 28, 2025 16:36
2709b0a to
e301c92
Compare
daniel-sanche
force-pushed
the
patch_app_profile_header
branch
from
April 28, 2025 17:00
eb8b2c2 to
cf59221
Compare
daniel-sanche
marked this pull request as ready for review
April 29, 2025 22:01
gkevinzheng
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've previously added temporary changes to attach empty string app_profile_id routing headers. This PR makes a change to owlbot.py to ensure the change persists between gapic changes
This is only strictly needed for execute_query and prepare_query, but for simplicity I made the change across all rpcs
Long term, the backend should change, since empty string routing headers is out of spec