Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

tests: adding support for array testing in postgres - #874

Merged
asthamohta merged 6 commits into
googleapis:mainfrom
asthamohta:jsonb-array
Dec 27, 2022
Merged

tests: adding support for array testing in postgres#874
asthamohta merged 6 commits into
googleapis:mainfrom
asthamohta:jsonb-array

Conversation

@asthamohta

Copy link
Copy Markdown
Contributor

No description provided.

@asthamohta
asthamohta requested review from a team December 26, 2022 17:18
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Dec 26, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 26, 2022
Comment thread tests/system/test_session_api.py Outdated
Comment thread tests/system/test_session_api.py Outdated
PostGresAllTypesRowData(pkey=302, bool_array=[True, False, None]),
PostGresAllTypesRowData(pkey=303, bytes_array=[BYTES_1, BYTES_2, None]),
PostGresAllTypesRowData(pkey=304, date_array=[SOME_DATE, None]),
PostGresAllTypesRowData(pkey=305, float_array=[3.1415926, 2.71828, None]),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check for POS_INF, and NEG_INF as well?

@rajatbhatta rajatbhatta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

@asthamohta
asthamohta merged commit f4db562 into googleapis:main Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants