fix(decode): preserve mapKeyConverter in Decoder#clone() - #295
Open
maximilliangrand wants to merge 1 commit into
Open
fix(decode): preserve mapKeyConverter in Decoder#clone()#295maximilliangrand wants to merge 1 commit into
maximilliangrand wants to merge 1 commit into
Conversation
Decoder#clone() is used for re-entrant decoding (e.g. an extension codec that decodes nested MessagePack on the same Decoder instance, issue msgpack#195). It copied every decoder option except mapKeyConverter, so any map decoded re-entrantly silently fell back to the default key converter instead of the one the caller configured. Copy mapKeyConverter in clone() alongside the other options, and add a regression test that decodes a nested map through an extension codec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Decoder#clone()is used for re-entrant decoding — for example an extension codec that decodes nested MessagePack on the same reusableDecoderinstance (the pattern from #195).clone()copies every decoder option exceptmapKeyConverter, so any map decoded re-entrantly silently falls back to the default key converter instead of the one the caller configured.Repro (converter upper-cases keys; extension type 1 re-enters the same decoder):
Fix
Copy
mapKeyConverterinclone()alongside the other options (keyDecoderand themax*limits are already copied). One line, plus a regression test that decodes a nested map through an extension codec.Full suite: 328 passing; lint and typecheck clean.