Skip to content

AWS Secret Manager for DB credentials - #135

Open
mehulmathur16 wants to merge 8 commits into
scratchdata:mainfrom
mehulmathur16:feat/db-creds-aws
Open

AWS Secret Manager for DB credentials #135
mehulmathur16 wants to merge 8 commits into
scratchdata:mainfrom
mehulmathur16:feat/db-creds-aws

Conversation

@mehulmathur16

@mehulmathur16 mehulmathur16 commented Mar 24, 2024

Copy link
Copy Markdown
Contributor

/claim #126
/fixes #126

Hi @poundifdef, I have tested out the memory vault & aws vault & it is working as expected.

The aws config looks like this :

vault:
  type: aws
  settings:
    AccessKey: "YOUR_AWS_ACCESS_KEY"
    SecretKey: "YOUR_AWS_SECRET_KEY"
    Prefix: "YOUR_PREFIX"
    Region: "us-east-1"

@algora-pbc algora-pbc Bot mentioned this pull request Mar 24, 2024
Open
8 tasks
@mehulmathur16

mehulmathur16 commented Mar 24, 2024

Copy link
Copy Markdown
Contributor Author

The below video shows the working with both vaults.

470c533d-f1c9-46f9-b545-71e499f210a1.mp4

On AWS console:

image image

@mehulmathur16

mehulmathur16 commented Mar 25, 2024

Copy link
Copy Markdown
Contributor Author

Hi @poundifdef, can you please review this PR ?

poundifdef
poundifdef requested changes Mar 25, 2024
View reviewed changes
Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/storage/vault/vault.go Outdated
Comment thread pkg/destinations/destinations.go Outdated
@mehulmathur16

mehulmathur16 commented Mar 25, 2024

Copy link
Copy Markdown
Contributor Author

Hi @poundifdef, I have resolved the above comments. Can you please review ?

@mehulmathur16

mehulmathur16 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Hi @poundifdef , can you please review the updated changes ?

@poundifdef

poundifdef commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

I haven't forgotten, I'll be sure to let you know when I've tested. Thanks!

@mehulmathur16

mehulmathur16 commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

Sure @poundifdef 👍

@mehulmathur16

mehulmathur16 commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @poundifdef, There appear to be a lot of structural changes on main branch. My work was based on the old structure as described by you in the issue description. Can you tell if the requirements are a bit changed now ?

Could you please provide an update on the direction we are heading with regard to this issue?

poundifdef
poundifdef requested changes Mar 31, 2024
View reviewed changes

@poundifdef poundifdef left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that the project structure has changed on the main branch, however, it is okay for you to keep the current structure of the code. I will handle rebasing myself.

Comment thread pkg/storage/vault/aws/aws.go Outdated
Comment thread pkg/storage/vault/memory/memory.go
Comment thread pkg/storage/vault/aws/aws.go Outdated
@mehulmathur16

mehulmathur16 commented Mar 31, 2024

Copy link
Copy Markdown
Contributor Author

@poundifdef I have resolved your comments. Please have a look.

@mehulmathur16

mehulmathur16 commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@poundifdef are we good to go with the updated changes ?

@poundifdef

poundifdef commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

Looks good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poundifdef poundifdef poundifdef requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use a AWS Secret Manager for DB credentials

2 participants

@mehulmathur16 @poundifdef