Conversation
Closed
Poolid function fix; Splitting methods to contract's calls wraps and market functions.
Pool manager ABI added; Poolid function fix; Splitting methods to contract's calls wraps and market functions.
UniswapV4 alpha
ErikBjare
marked this pull request as ready for review
January 8, 2024 08:47
and more
and more
and more!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
===========================================
- Coverage 71.22% 52.26% -18.97%
===========================================
Files 11 12 +1
Lines 1074 1280 +206
===========================================
- Hits 765 669 -96
- Misses 309 611 +302 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
price fetching refactored; custom gas pricing; misc
typing fixes
typing fix 2
typing fixes
some more fixes
Member
|
@ErikBjare ^^ |
ABIs update
final fixes and clean-ups
typing fix
more stupidity fix
ErikBjare
commented
Jun 10, 2024
Co-authored-by: Erik Bjäreholt <erik@bjareho.lt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a PR with all the changes in the
dev/v4branch.Closes #337